My First Patch for Drupal
Wed, 10/10/2007 - 8:40am — Nick
Instead of doing something sane last night1 I spent a few hours creating and submitting my first patch to a Drupal module. I attempted to follow the Drupal coding standards and taking advantage of the Drupal API, but I'm sure I've made a mistake somewhere. Hopefully, a few other eyes review the patch and point out the problems with it.
And I'm only a few weeks late on getting it out too. Actually, not just diving in that weekend and waiting a bit was probably best as I ended up getting a better idea of how to get around the problem.
- 1. like sleeping
- ‹ previous
- 82 of 111
- next ›
Comments
How did you fix the technorati issue?
Hi Nick -- I found your patch after having the same issue with technorati indexing the comments feed instead of the "real" site-wide feed. Could you let me know how you got technorati to re-index the correct feed? My blog's technorati page seems stuck on the comments feed...
Hope your patch gets accepted into the commentrss module, though I agree that the best fix would be to have a 'weighting' for feeds, according to which they could then be sorted in the meta tag section.
I actually disabled the
I actually disabled the commentrss module when I first noticed the problem with technorati, so it eventually just picked up my main feed again after some time. But much like how technorati switched from picking up the main feed to the comments feed, it should eventually pick up the main feed again if that's listed first/the only one listed. Granted, I haven't setup the patch on my own blogs yet.
By the way, why don't you leave a comment on the issue if the patch worked for you on the issue page at Drupal's site? It's probably the best way to get wider exposure of the problems, plus I would appreciate it if you leave some ideas or criticism of my fixes on there.